CU-862hyd5wx Rosalind down #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fail meaningfully in case of 503
…hen Rosalind is down
tomolopolis
approved these changes
Dec 22, 2022
|
I will be merging this in around 2h if nobody has any objections before that. |
|
It seems the Rosalind issue is now resolved. And the CIs have been re-run and are passing. So there's no rush in merging this PR. So I'll leave it up until the new year in case someone has concerns. But I think it's still good to have an alternative in case the link becomes unresponsive again at some point in the future. Plus, it'll be able to identify the |
mart-r
added a commit
to mart-r/MedCAT
that referenced
this pull request
Jun 14, 2023
CU-862hyd5wx Workaround for when Rosalind is down and/or fixes the downloaded 503
mart-r
added a commit
that referenced
this pull request
Oct 12, 2023
CU-862hyd5wx Workaround for when Rosalind is down and/or fixes the downloaded 503
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rosalind is currently down. Some MedCAT tests rely on downloading a
Vocabfrommedcat.rosalind.kcl.ac.uk/media/vocab.dat. When that is not available (currently returns 503), the tests fail since theVocabis (understandably) unable to be loaded from the web response (the 503).Because of the above, GHA/CIs keep failing due to the test failures.
What this PR does:
Vocabdownloadstmp_vocab.dathas the 503 infoVocabto useVocabis the generated simple oneMade sure the tests run and succeed in 4 cases
tmp_vocab.dattmp_vocab.dattmp_vocab.datfrom Rosalindtmp_vocab.datthat contains the 503PS:
I've made sure all tests run and are successful with the generated
Vocab. But I have not checked specifically whether they run in the same exact way they would be expected with the realVocab. Because this generatedVocabhas only 2 words, iterating over those may result in different behaviour compared to the real deal.